Fixing an extra FORMAT JSON in the query when attempting to insert a record#262
Open
AlexandrFiner wants to merge 1 commit into
Open
Fixing an extra FORMAT JSON in the query when attempting to insert a record#262AlexandrFiner wants to merge 1 commit into
FORMAT JSON in the query when attempting to insert a record#262AlexandrFiner wants to merge 1 commit into
Conversation
… using a regular expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ON CLUSTER, an extraFORMAT JSONis added, which breaks the queryProblem
ON CLUSTERin a query does not take into account that it may be part of the dataSolution
stripos()check is used as a first-level filter to detect the presence of ON CLUSTER in the SQL string.preg_match()is only executed when the substring is present, providing a strict validation of the ON CLUSTER keyword.ON CLUSTERonly as a SQL keyword, ignoring occurrences inside string literals.